fix(ct): adapt API tests to sole Default personal

Default create_calendar to commercial; reuse existing personal on 409;
assert verify title Default; cover personal_exists / default_calendar.

Refs EventHub/EventHubBack#64

test/api/users/user_calendar_by_id_tests.erl

@@ -15,9 +15,8 @@ test() ->
   OtherToken = api_test_runner:register_and_login(
     api_test_runner:unique_email(<<"other">>), <<"pass">>),
 
-  % Создаём календарь для тестов
-  #{<<"id">> := CalId} = api_test_runner:client_post(<<"/v1/calendars">>, Token,
-    #{title => <<"TestCal">>, type => <<"personal">>}),
+  %% Studio calendar (sole personal Default cannot be deleted)
+  CalId = api_test_runner:create_calendar(Token, #{title => <<"TestCal">>}),
 
   test_get_calendar(Token, CalId),
   test_get_calendar_unauthorized(CalId),
@@ -26,6 +25,7 @@ test() ->
   test_update_calendar_settings(Token, CalId),
   test_update_calendar_forbidden(OtherToken, CalId),
   test_delete_calendar(Token, CalId),
+  test_delete_default_personal_forbidden(Token),
   test_delete_calendar_forbidden(OtherToken, CalId),
 
   ct:pal("=== All user calendar by id tests passed ==="),
@@ -104,19 +104,25 @@ test_update_calendar_forbidden(OtherToken, CalId) ->
   ct:pal("    OK: got 403").
 
 test_delete_calendar(Token, CalId) ->
-  ct:pal("  TEST: Delete calendar (soft-delete)"),
+  ct:pal("  TEST: Delete studio calendar (soft-delete)"),
   Path = <<"/v1/calendars/", CalId/binary>>,
   Resp = api_test_runner:client_request(delete, Path, Token),
   ?assertMatch({ok, 200, _, _}, Resp),
   ct:pal("    OK: deleted").
 
-test_delete_calendar_forbidden(OtherToken, CalId) ->
-  % Первый раз мы уже удалили, но проверим на другом календаре
+test_delete_default_personal_forbidden(Token) ->
+  ct:pal("  TEST: Delete sole personal calendar (403 default_calendar)"),
+  PersonalId = api_test_runner:existing_personal_calendar_id(Token),
+  Path = <<"/v1/calendars/", PersonalId/binary>>,
+  Resp = api_test_runner:client_request(delete, Path, Token),
+  ?assertMatch({ok, 403, _, _}, Resp),
+  ct:pal("    OK: got 403 default_calendar").
+
+test_delete_calendar_forbidden(OtherToken, _DeletedCalId) ->
   ct:pal("  TEST: Delete calendar by non-owner (403)"),
-  % Создадим новый календарь владельцем Token, попробуем удалить OtherToken
-  #{<<"id">> := NewCalId} = api_test_runner:client_post(<<"/v1/calendars">>, api_test_runner:get_user_token(),
-    #{title => <<"ForbiddenDel">>, type => <<"personal">>}),
+  OwnerToken = api_test_runner:get_user_token(),
+  NewCalId = api_test_runner:create_calendar(OwnerToken, #{title => <<"ForbiddenDel">>}),
   Path = <<"/v1/calendars/", NewCalId/binary>>,
   Resp = api_test_runner:client_request(delete, Path, OtherToken),
   ?assertMatch({ok, 403, _, _}, Resp),
-  ct:pal("    OK: got 403").
+  ct:pal("    OK: got 403").

test/api/users/user_calendars_tests.erl

@@ -13,11 +13,10 @@ test() ->
   ct:pal("=== User Calendars Tests ==="),
   Token = api_test_runner:get_user_token(),
 
-  % Создаём один календарь для тестов
-  #{<<"id">> := CalId} = api_test_runner:client_post(<<"/v1/calendars">>, Token,
-    #{title => <<"TestCal">>, type => <<"personal">>}),
+  _CalId = api_test_runner:create_calendar(Token, #{title => <<"TestCal">>}),
 
   test_create_calendar(Token),
+  test_second_personal_rejected(Token),
   test_list_calendars(Token),
   test_list_calendars_unauthorized(),
 
@@ -25,15 +24,23 @@ test() ->
   ok.
 
 test_create_calendar(Token) ->
-  ct:pal("  TEST: Create a new calendar"),
+  ct:pal("  TEST: Create a new studio calendar"),
+  api_test_runner:ensure_commercial_subscription(Token),
   Resp = api_test_runner:client_request(post, <<"/v1/calendars">>, Token,
-    jsx:encode(#{title => <<"NewCal">>, type => <<"personal">>})),
+    jsx:encode(#{title => <<"NewCal">>, type => <<"commercial">>})),
   {ok, 201, _, Body} = Resp,
   #{<<"id">> := Id, <<"title">> := Title} = jsx:decode(list_to_binary(Body), [return_maps]),
   ?assert(is_binary(Id)),
   ?assertEqual(<<"NewCal">>, Title),
   ct:pal("    OK: created calendar ~s", [Id]).
 
+test_second_personal_rejected(Token) ->
+  ct:pal("  TEST: Second personal calendar rejected (409)"),
+  Resp = api_test_runner:client_request(post, <<"/v1/calendars">>, Token,
+    jsx:encode(#{title => <<"AnotherPersonal">>, type => <<"personal">>})),
+  ?assertMatch({ok, 409, _, _}, Resp),
+  ct:pal("    OK: got 409 personal_exists").
+
 test_list_calendars(Token) ->
   ct:pal("  TEST: List user calendars"),
   Calendars = api_test_runner:client_get(<<"/v1/calendars">>, Token),

test/api/users/user_verification_tests.erl

@@ -47,17 +47,13 @@ test() ->
   #{<<"token">> := AuthToken} = jsx:decode(list_to_binary(LoginBody), [return_maps]),
   ?assert(is_binary(AuthToken)),
 
-  % 6. После активации — дефолтный приватный personal-календарь
+  % 6. После активации — единственный personal с title Default
   Calendars = api_test_runner:client_get(<<"/v1/calendars">>, AuthToken),
   ?assertEqual(1, length(Calendars)),
   [DefaultCal] = Calendars,
   ?assertEqual(<<"personal">>, maps:get(<<"type">>, DefaultCal)),
   ?assertEqual(<<>>, maps:get(<<"short_name">>, DefaultCal)),
-  ExpectedTitle = case string:split(Email, <<"@">>) of
-                    [Local, _] when byte_size(Local) > 0 -> Local;
-                    _ -> <<"Мой календарь">>
-                  end,
-  ?assertEqual(ExpectedTitle, maps:get(<<"title">>, DefaultCal)),
+  ?assertEqual(<<"Default">>, maps:get(<<"title">>, DefaultCal)),
 
   % 7. Повторное использование того же токена – ошибка 404
   {ok, 404, _, _} = api_test_runner:client_request(post, <<"/v1/verify">>, <<>>,