Рефакторинг обработчиков. Часть 2 #21
This commit is contained in:
@@ -1,42 +1,149 @@
|
||||
%%%-------------------------------------------------------------------
|
||||
%%% @doc Обработчик конкретного отзыва (клиентский API).
|
||||
%%%
|
||||
%%% GET – получить отзыв по ID.
|
||||
%%% PUT – обновить отзыв (владельцем).
|
||||
%%% DELETE – удалить отзыв (владельцем).
|
||||
%%% @end
|
||||
%%%-------------------------------------------------------------------
|
||||
-module(handler_review_by_id).
|
||||
-include("records.hrl").
|
||||
-behaviour(cowboy_handler).
|
||||
|
||||
-export([init/2]).
|
||||
-export([trails/0]).
|
||||
|
||||
-include("records.hrl").
|
||||
|
||||
%%% cowboy_handler callback
|
||||
-spec init(cowboy_req:req(), any()) -> {ok, cowboy_req:req(), any()}.
|
||||
init(Req, Opts) ->
|
||||
handle(Req, Opts).
|
||||
|
||||
%%% Swagger metadata
|
||||
-spec trails() -> [map()].
|
||||
trails() ->
|
||||
BaseParams = [
|
||||
#{
|
||||
name => <<"id">>,
|
||||
in => <<"path">>,
|
||||
description => <<"Review ID">>,
|
||||
required => true,
|
||||
schema => #{type => string}
|
||||
}
|
||||
],
|
||||
[
|
||||
#{ % GET by id
|
||||
path => <<"/v1/reviews/:id">>,
|
||||
method => <<"GET">>,
|
||||
description => <<"Get review by ID">>,
|
||||
tags => [<<"Reviews">>],
|
||||
parameters => BaseParams,
|
||||
responses => #{
|
||||
200 => #{
|
||||
description => <<"Review details">>,
|
||||
content => #{<<"application/json">> => #{schema => review_schema()}}
|
||||
},
|
||||
403 => #{description => <<"Access denied">>},
|
||||
404 => #{description => <<"Review not found">>}
|
||||
}
|
||||
},
|
||||
#{ % PUT update
|
||||
path => <<"/v1/reviews/:id">>,
|
||||
method => <<"PUT">>,
|
||||
description => <<"Update review">>,
|
||||
tags => [<<"Reviews">>],
|
||||
parameters => BaseParams,
|
||||
requestBody => #{
|
||||
required => true,
|
||||
content => #{<<"application/json">> => #{schema => review_update_schema()}}
|
||||
},
|
||||
responses => #{
|
||||
200 => #{description => <<"Review updated">>},
|
||||
400 => #{description => <<"Invalid request">>},
|
||||
403 => #{description => <<"Access denied">>},
|
||||
404 => #{description => <<"Review not found">>}
|
||||
}
|
||||
},
|
||||
#{ % DELETE
|
||||
path => <<"/v1/reviews/:id">>,
|
||||
method => <<"DELETE">>,
|
||||
description => <<"Delete review">>,
|
||||
tags => [<<"Reviews">>],
|
||||
parameters => BaseParams,
|
||||
responses => #{
|
||||
200 => #{description => <<"Review deleted">>},
|
||||
403 => #{description => <<"Access denied">>},
|
||||
404 => #{description => <<"Review not found">>}
|
||||
}
|
||||
}
|
||||
].
|
||||
|
||||
review_schema() ->
|
||||
#{
|
||||
type => object,
|
||||
properties => #{
|
||||
id => #{type => string},
|
||||
user_id => #{type => string},
|
||||
target_type => #{type => string, enum => [<<"calendar">>, <<"event">>]},
|
||||
target_id => #{type => string},
|
||||
rating => #{type => integer, minimum => 1, maximum => 5},
|
||||
comment => #{type => string},
|
||||
status => #{type => string, enum => [<<"visible">>, <<"hidden">>, <<"deleted">>]},
|
||||
reason => #{type => string, nullable => true},
|
||||
likes => #{type => integer},
|
||||
dislikes => #{type => integer},
|
||||
created_at => #{type => string, format => <<"date-time">>},
|
||||
updated_at => #{type => string, format => <<"date-time">>}
|
||||
}
|
||||
}.
|
||||
|
||||
review_update_schema() ->
|
||||
#{
|
||||
type => object,
|
||||
properties => #{
|
||||
rating => #{type => integer, minimum => 1, maximum => 5},
|
||||
comment => #{type => string}
|
||||
}
|
||||
}.
|
||||
|
||||
%%%===================================================================
|
||||
%%% HTTP-методы
|
||||
%%%===================================================================
|
||||
|
||||
%% @private
|
||||
-spec handle(cowboy_req:req(), any()) -> {ok, cowboy_req:req(), any()}.
|
||||
handle(Req, _Opts) ->
|
||||
case cowboy_req:method(Req) of
|
||||
<<"GET">> -> get_review(Req);
|
||||
<<"PUT">> -> update_review(Req);
|
||||
<<"GET">> -> get_review(Req);
|
||||
<<"PUT">> -> update_review(Req);
|
||||
<<"DELETE">> -> delete_review(Req);
|
||||
_ -> send_error(Req, 405, <<"Method not allowed">>)
|
||||
_ -> handler_utils:send_error(Req, 405, <<"Method not allowed">>)
|
||||
end.
|
||||
|
||||
%% GET /v1/reviews/:id - получение отзыва
|
||||
%% @doc GET /v1/reviews/:id — получение отзыва.
|
||||
-spec get_review(cowboy_req:req()) -> {ok, binary(), cowboy_req:req()}.
|
||||
get_review(Req) ->
|
||||
case handler_auth:authenticate(Req) of
|
||||
case handler_utils:auth_user(Req) of
|
||||
{ok, UserId, Req1} ->
|
||||
ReviewId = cowboy_req:binding(id, Req1),
|
||||
case logic_review:get_review(UserId, ReviewId) of
|
||||
{ok, Review} ->
|
||||
Response = review_to_json(Review),
|
||||
send_json(Req1, 200, Response);
|
||||
handler_utils:send_json(Req1, 200, handler_utils:review_to_json(Review));
|
||||
{error, access_denied} ->
|
||||
send_error(Req1, 403, <<"Access denied">>);
|
||||
handler_utils:send_error(Req1, 403, <<"Access denied">>);
|
||||
{error, not_found} ->
|
||||
send_error(Req1, 404, <<"Review not found">>);
|
||||
handler_utils:send_error(Req1, 404, <<"Review not found">>);
|
||||
{error, _} ->
|
||||
send_error(Req1, 500, <<"Internal server error">>)
|
||||
handler_utils:send_error(Req1, 500, <<"Internal server error">>)
|
||||
end;
|
||||
{error, Code, Message, Req1} ->
|
||||
send_error(Req1, Code, Message)
|
||||
handler_utils:send_error(Req1, Code, Message)
|
||||
end.
|
||||
|
||||
%% PUT /v1/reviews/:id - обновление отзыва
|
||||
%% @doc PUT /v1/reviews/:id — обновление отзыва.
|
||||
-spec update_review(cowboy_req:req()) -> {ok, binary(), cowboy_req:req()}.
|
||||
update_review(Req) ->
|
||||
case handler_auth:authenticate(Req) of
|
||||
case handler_utils:auth_user(Req) of
|
||||
{ok, UserId, Req1} ->
|
||||
ReviewId = cowboy_req:binding(id, Req1),
|
||||
{ok, Body, Req2} = cowboy_req:read_body(Req1),
|
||||
@@ -45,74 +152,44 @@ update_review(Req) ->
|
||||
Updates = maps:to_list(UpdatesMap),
|
||||
case logic_review:update_review(UserId, ReviewId, Updates) of
|
||||
{ok, _} ->
|
||||
% Получаем обновлённый отзыв из базы
|
||||
case core_review:get_by_id(ReviewId) of
|
||||
{ok, Updated} ->
|
||||
Response = review_to_json(Updated),
|
||||
send_json(Req2, 200, Response);
|
||||
handler_utils:send_json(Req2, 200, handler_utils:review_to_json(Updated));
|
||||
_ ->
|
||||
send_error(Req2, 500, <<"Failed to retrieve updated review">>)
|
||||
handler_utils:send_error(Req2, 500, <<"Failed to retrieve updated review">>)
|
||||
end;
|
||||
{error, access_denied} ->
|
||||
send_error(Req2, 403, <<"Access denied">>);
|
||||
handler_utils:send_error(Req2, 403, <<"Access denied">>);
|
||||
{error, not_found} ->
|
||||
send_error(Req2, 404, <<"Review not found">>);
|
||||
handler_utils:send_error(Req2, 404, <<"Review not found">>);
|
||||
{error, _} ->
|
||||
send_error(Req2, 500, <<"Internal server error">>)
|
||||
handler_utils:send_error(Req2, 500, <<"Internal server error">>)
|
||||
end;
|
||||
_ ->
|
||||
send_error(Req2, 400, <<"Invalid JSON">>)
|
||||
handler_utils:send_error(Req2, 400, <<"Invalid JSON">>)
|
||||
catch
|
||||
_:_ ->
|
||||
send_error(Req2, 400, <<"Invalid JSON format">>)
|
||||
_:_ -> handler_utils:send_error(Req2, 400, <<"Invalid JSON format">>)
|
||||
end;
|
||||
{error, Code, Message, Req1} ->
|
||||
send_error(Req1, Code, Message)
|
||||
handler_utils:send_error(Req1, Code, Message)
|
||||
end.
|
||||
|
||||
%% DELETE /v1/reviews/:id - удаление отзыва
|
||||
%% @doc DELETE /v1/reviews/:id — удаление отзыва.
|
||||
-spec delete_review(cowboy_req:req()) -> {ok, binary(), cowboy_req:req()}.
|
||||
delete_review(Req) ->
|
||||
case handler_auth:authenticate(Req) of
|
||||
case handler_utils:auth_user(Req) of
|
||||
{ok, UserId, Req1} ->
|
||||
ReviewId = cowboy_req:binding(id, Req1),
|
||||
case logic_review:delete_review(UserId, ReviewId) of
|
||||
{ok, deleted} ->
|
||||
send_json(Req1, 200, #{status => <<"deleted">>});
|
||||
handler_utils:send_json(Req1, 200, #{status => <<"deleted">>});
|
||||
{error, access_denied} ->
|
||||
send_error(Req1, 403, <<"Access denied">>);
|
||||
handler_utils:send_error(Req1, 403, <<"Access denied">>);
|
||||
{error, not_found} ->
|
||||
send_error(Req1, 404, <<"Review not found">>);
|
||||
handler_utils:send_error(Req1, 404, <<"Review not found">>);
|
||||
{error, _} ->
|
||||
send_error(Req1, 500, <<"Internal server error">>)
|
||||
handler_utils:send_error(Req1, 500, <<"Internal server error">>)
|
||||
end;
|
||||
{error, Code, Message, Req1} ->
|
||||
send_error(Req1, Code, Message)
|
||||
end.
|
||||
|
||||
%% Вспомогательные функции
|
||||
review_to_json(Review) ->
|
||||
#{
|
||||
id => Review#review.id,
|
||||
user_id => Review#review.user_id,
|
||||
target_type => Review#review.target_type,
|
||||
target_id => Review#review.target_id,
|
||||
rating => Review#review.rating,
|
||||
comment => Review#review.comment,
|
||||
status => Review#review.status,
|
||||
created_at => datetime_to_iso8601(Review#review.created_at),
|
||||
updated_at => datetime_to_iso8601(Review#review.updated_at)
|
||||
}.
|
||||
|
||||
datetime_to_iso8601({{Year, Month, Day}, {Hour, Minute, Second}}) ->
|
||||
iolist_to_binary(io_lib:format("~4..0B-~2..0B-~2..0BT~2..0B:~2..0B:~2..0BZ",
|
||||
[Year, Month, Day, Hour, Minute, Second])).
|
||||
|
||||
send_json(Req, Status, Data) ->
|
||||
Body = jsx:encode(Data),
|
||||
cowboy_req:reply(Status, #{<<"content-type">> => <<"application/json">>}, Body, Req),
|
||||
{ok, Body, []}.
|
||||
|
||||
send_error(Req, Status, Message) ->
|
||||
Body = jsx:encode(#{error => Message}),
|
||||
cowboy_req:reply(Status, #{<<"content-type">> => <<"application/json">>}, Body, Req),
|
||||
{ok, Body, []}.
|
||||
handler_utils:send_error(Req1, Code, Message)
|
||||
end.
|
||||
Reference in New Issue
Block a user